summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPablo Neira Ayuso <pablo@netfilter.org>2012-09-08 21:39:21 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2012-09-08 22:44:03 +0200
commit46faeab56cf4117f41cb6f1f1c40a9c18a81372f (patch)
tree6f3851a8b27e4c4e40b0103235f1ff53d6bc921b
parentc9698ed05f450f9c32b8c1342c42b584988102de (diff)
conntrackd: parse: fix wrong maximum length for ATTR_EXP_FN
It was set to NFCT_HELPER_NAME_MAX (16 bytes), but we have function names that are larger, eg. nf-nat-follow-master which is 18 bytes long. This leads to hitting malformed message while synchronizing expectations. I'll add some new constant to libnetfilter_conntrack instead of hardcoding this, later. Reported-by: Gaurav Sinha <gaurav.sinha@vyatta.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
-rw-r--r--src/parse.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/parse.c b/src/parse.c
index 1b83f81..8ce4495 100644
--- a/src/parse.c
+++ b/src/parse.c
@@ -397,7 +397,7 @@ static struct exp_parser {
[NTA_EXP_FN] = {
.parse = exp_parse_str,
.exp_attr = ATTR_EXP_FN,
- .max_size = NFCT_HELPER_NAME_MAX,
+ .max_size = 32, /* XXX: artificial limit */
},
};