summaryrefslogtreecommitdiffstats
path: root/src/helpers/ftp.c
diff options
context:
space:
mode:
authorKevin Cernekee <cernekee@chromium.org>2017-01-26 16:44:24 -0800
committerPablo Neira Ayuso <pablo@netfilter.org>2017-02-01 18:05:04 +0100
commit1ba5e76a368aeb9fe17d3b691df4faa0dadc4523 (patch)
treefabfb1c99ce1943957ab34334c7b194816ca3193 /src/helpers/ftp.c
parent8b837716369724287f768531b813501c4ba80f38 (diff)
conntrackd: cthelper: Don't leak nat_tuple
nfexp_set_attr() copies |nat_tuple| rather than taking ownership, so it should be freed at the end of the loop. Some of the other helpers (like rpc.c) do this, but it is missing here. Reported-by: Eric Caruso <ejcaruso@chromium.org> Signed-off-by: Kevin Cernekee <cernekee@chromium.org> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/helpers/ftp.c')
-rw-r--r--src/helpers/ftp.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/helpers/ftp.c b/src/helpers/ftp.c
index 27ab5eb..c3aa284 100644
--- a/src/helpers/ftp.c
+++ b/src/helpers/ftp.c
@@ -423,6 +423,7 @@ static unsigned int nf_nat_ftp(struct pkt_buff *pkt,
break;
}
}
+ nfct_destroy(nat_tuple);
if (port == 0)
return NF_DROP;