From 7c5f4b390f4b8dc02aceb0a18ed7c59ff14f392c Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Tue, 10 Sep 2019 14:02:30 +0200 Subject: nfct: helper: Fix NFCTH_ATTR_PROTO_L4NUM size Kernel defines NFCTH_TUPLE_L4PROTONUM as of type NLA_U8. When adding a helper, NFCTH_ATTR_PROTO_L4NUM attribute is correctly set using nfct_helper_attr_set_u8(), though when deleting nfct_helper_attr_set_u32() was incorrectly used. Due to alignment, this causes trouble only on Big Endian. Fixes: 5e8f64f46cb1d ("conntrackd: add cthelper infrastructure (+ example FTP helper)") Signed-off-by: Phil Sutter Acked-by: Pablo Neira Ayuso --- src/nfct-extensions/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/nfct-extensions/helper.c b/src/nfct-extensions/helper.c index 0569827..e5d8d0a 100644 --- a/src/nfct-extensions/helper.c +++ b/src/nfct-extensions/helper.c @@ -284,7 +284,7 @@ nfct_cmd_helper_delete(struct mnl_socket *nl, int argc, char *argv[]) nfct_perror("unsupported layer 4 protocol"); return -1; } - nfct_helper_attr_set_u32(t, NFCTH_ATTR_PROTO_L4NUM, l4proto); + nfct_helper_attr_set_u8(t, NFCTH_ATTR_PROTO_L4NUM, l4proto); } seq = time(NULL); -- cgit v1.2.3