From 50fb8a8e986ca7a99987538d51435e72d4346f40 Mon Sep 17 00:00:00 2001 From: Bart De Schuymer Date: Thu, 23 Jun 2011 18:42:28 +0000 Subject: remove irrelevant negative value check for the result of strtoul, found by Coverity static analysis (thanks to Jiri Popelka) --- extensions/ebt_nflog.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/extensions/ebt_nflog.c b/extensions/ebt_nflog.c index 259bdb2..0cd10e0 100644 --- a/extensions/ebt_nflog.c +++ b/extensions/ebt_nflog.c @@ -80,8 +80,6 @@ static int nflog_parse(int c, char **argv, int argc, i = strtoul(optarg, &end, 10); if (*end != '\0') ebt_print_error2("--nflog-group must be a number!"); - if (i < 0) - ebt_print_error2("--nflog-group can not be negative"); info->group = i; break; @@ -92,8 +90,6 @@ static int nflog_parse(int c, char **argv, int argc, i = strtoul(optarg, &end, 10); if (*end != '\0') ebt_print_error2("--nflog-range must be a number!"); - if (i < 0) - ebt_print_error2("--nflog-range can not be negative"); info->len = i; break; @@ -104,9 +100,6 @@ static int nflog_parse(int c, char **argv, int argc, i = strtoul(optarg, &end, 10); if (*end != '\0') ebt_print_error2("--nflog-threshold must be a number!"); - if (i < 0) - ebt_print_error2 - ("--nflog-threshold can not be negative"); info->threshold = i; break; case NFLOG_NFLOG: -- cgit v1.2.3