diff options
| author | Gustavo A. R. Silva <garsilva@embeddedor.com> | 2017-10-30 17:19:25 -0500 |
|---|---|---|
| committer | Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> | 2017-11-06 09:37:31 +0100 |
| commit | e2a84a4a7bb8cdebfe4c0990b79179e2fd717a48 (patch) | |
| tree | 8b58ef435617f5072aaf7ce94d6bcc3ee9fa615a /kernel/net/netfilter/ipset/ip_set_bitmap_port.c | |
| parent | 99f04e60f5aec76c4ba6a4a0104ba2a5ae87e235 (diff) | |
netfilter: ipset: use swap macro instead of _manually_ swapping values
Make use of the swap macro and remove unnecessary variables tmp.
This makes the code easier to read and maintain.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Diffstat (limited to 'kernel/net/netfilter/ipset/ip_set_bitmap_port.c')
| -rw-r--r-- | kernel/net/netfilter/ipset/ip_set_bitmap_port.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/kernel/net/netfilter/ipset/ip_set_bitmap_port.c b/kernel/net/netfilter/ipset/ip_set_bitmap_port.c index 7f0c733..c6e1ebf 100644 --- a/kernel/net/netfilter/ipset/ip_set_bitmap_port.c +++ b/kernel/net/netfilter/ipset/ip_set_bitmap_port.c @@ -236,12 +236,8 @@ bitmap_port_create(struct net *net, struct ip_set *set, struct nlattr *tb[], first_port = ip_set_get_h16(tb[IPSET_ATTR_PORT]); last_port = ip_set_get_h16(tb[IPSET_ATTR_PORT_TO]); - if (first_port > last_port) { - u16 tmp = first_port; - - first_port = last_port; - last_port = tmp; - } + if (first_port > last_port) + swap(first_port, last_port); elements = last_port - first_port + 1; set->dsize = ip_set_elem_len(set, tb, 0, 0); |