From 20125f0086b5fddcef9f909e6e4aab475552eaba Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 28 Oct 2011 18:16:13 +0200 Subject: ipset: fix lookup of tcp port names The protocol argument to getservbyname() must be lowercase tcp not uppercase TCP. This fixes the bug observed by: # ipset add foo http ipset v6.9.1: Syntax error: 'http' is invalid as number Syntax error: cannot parse 'http' as a TCP port Signed-off-by: Jozsef Kadlecsik --- lib/parse.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'lib/parse.c') diff --git a/lib/parse.c b/lib/parse.c index 241d5ae..3ca702c 100644 --- a/lib/parse.c +++ b/lib/parse.c @@ -307,7 +307,7 @@ int ipset_parse_tcp_port(struct ipset_session *session, enum ipset_opt opt, const char *str) { - return ipset_parse_tcpudp_port(session, opt, str, "TCP"); + return ipset_parse_tcpudp_port(session, opt, str, "tcp"); } /** @@ -330,7 +330,7 @@ ipset_parse_single_tcp_port(struct ipset_session *session, assert(opt == IPSET_OPT_PORT || opt == IPSET_OPT_PORT_TO); assert(str); - return ipset_parse_port(session, opt, str, "TCP"); + return ipset_parse_port(session, opt, str, "tcp"); } /** -- cgit v1.2.3