diff options
| author | /C=DE/ST=Berlin/L=Berlin/O=Netfilter Project/OU=Development/CN=laforge/emailAddress=laforge@netfilter.org </C=DE/ST=Berlin/L=Berlin/O=Netfilter Project/OU=Development/CN=laforge/emailAddress=laforge@netfilter.org> | 2005-02-01 12:56:16 +0000 |
|---|---|---|
| committer | /C=DE/ST=Berlin/L=Berlin/O=Netfilter Project/OU=Development/CN=laforge/emailAddress=laforge@netfilter.org </C=DE/ST=Berlin/L=Berlin/O=Netfilter Project/OU=Development/CN=laforge/emailAddress=laforge@netfilter.org> | 2005-02-01 12:56:16 +0000 |
| commit | 8a8a26445af4839fdcd1ff703bdc07d020156365 (patch) | |
| tree | 8b96b759f0e3352eb00567e3446bd2106279266d /extensions/libipt_DNAT.c | |
| parent | 3bdfd505b438b5b4872e6754f0d895b328685c08 (diff) | |
John McCann points out via bugzilla that iptables happily accepts this
syntax on DNAT/SNAT:
--to x.x.x.x:y:z
but doesn't actually make use of the second port. Clear up the confusion
by only accepting a dash between the ports.
This closes bugzilla #265.
Signed-off-by: Phil Oester <kernel@linuxace.com>
Diffstat (limited to 'extensions/libipt_DNAT.c')
| -rw-r--r-- | extensions/libipt_DNAT.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/extensions/libipt_DNAT.c b/extensions/libipt_DNAT.c index d8efa58..96a6e6b 100644 --- a/extensions/libipt_DNAT.c +++ b/extensions/libipt_DNAT.c @@ -65,7 +65,7 @@ static struct ipt_entry_target * parse_to(char *arg, int portok, struct ipt_natinfo *info) { struct ip_nat_range range; - char *colon, *dash; + char *colon, *dash, *error; struct in_addr *ip; memset(&range, 0, sizeof(range)); @@ -85,6 +85,11 @@ parse_to(char *arg, int portok, struct ipt_natinfo *info) exit_error(PARAMETER_PROBLEM, "Port `%s' not valid\n", colon+1); + error = strchr(colon+1, ':'); + if (error) + exit_error(PARAMETER_PROBLEM, + "Invalid port:port syntax - use dash\n"); + dash = strchr(colon, '-'); if (!dash) { range.min.tcp.port |