summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@gnumonks.org>2003-04-13 11:29:28 +0000
committerHarald Welte <laforge@gnumonks.org>2003-04-13 11:29:28 +0000
commit710e7eb50e631f6f2ff98cce7a18b8f82e153f65 (patch)
tree5375ac818bb1618b0935b6a4895ae8388193d0e8
parent22b21353f551f6f96a25f92e32ccfb39e24af98f (diff)
add a few notes about how to deal with CVS COMMIT access
-rw-r--r--COMMIT_NOTES24
1 files changed, 24 insertions, 0 deletions
diff --git a/COMMIT_NOTES b/COMMIT_NOTES
new file mode 100644
index 00000000..e8b9e46f
--- /dev/null
+++ b/COMMIT_NOTES
@@ -0,0 +1,24 @@
+A quick list of rules for committing stuff into netfilter cvs:
+
+- Always include the Name of the Author/Contributor in the CVS comment
+ like 'fix for foo (Au Thor)'
+
+- make sure that you have set the executable bits on an 'extensions/.*-test'
+ script before adding/committing it to CVS
+
+- If the commit fixes a bugzilla bug, please include '(Closes: #bugnr)' in
+ the commit message
+
+- Make sure you don't commit to CVS while a feature freeze is announced
+
+- For new extensions, there are two possible cases:
+ 1) header files are just in patch-o-matic patch, you need an
+ 'extensions/.*-test' script to have a conditional build
+ 2) header files are in patch-o-matic patch, and copied to
+ 'netfilter/include/linux/netfilter_xxx'. This way the extension
+ can be built _unconditionally_, and thus be included in
+ 'extensions/Makefile'. Make sure to keep the headers in sync!
+
+ Usually '1)' is used, but in case something is expected to show up in the
+ kernel soon, we should already make userspace support unconditionally.
+