summaryrefslogtreecommitdiffstats
path: root/iptables.c
diff options
context:
space:
mode:
authorPablo Neira Ayuso <pablo@netfilter.org>2008-11-19 19:01:26 +0100
committerPablo Neira Ayuso <pablo@netfilter.org>2008-11-19 19:01:26 +0100
commit0e6b7d3171988cf745d4d99006459bcea99e6e34 (patch)
tree56b6c0ea4cbf34b7913cd8397b81cee8559977e3 /iptables.c
parent03d99486d8283552705b58dc55b6085dffc38792 (diff)
iptables: fix error reporting with wrong/missing arguments
This patch fixes wrong error reporting when arguments are missing: # iptables -I INPUT -m state --state iptables v1.4.2-rc1: Unknown arg `(null)' Try `iptables -h' or 'iptables --help' for more information. or wrong: # iptables -I INPUT -m state --xyz iptables v1.4.2-rc1: Unknown arg `(null)' Try `iptables -h' or 'iptables --help' for more information. Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'iptables.c')
-rw-r--r--iptables.c19
1 files changed, 18 insertions, 1 deletions
diff --git a/iptables.c b/iptables.c
index 2c6b4dcc..b75df871 100644
--- a/iptables.c
+++ b/iptables.c
@@ -1909,9 +1909,26 @@ int do_command(int argc, char *argv[], char **table, struct iptc_handle **handle
optind--;
continue;
}
- if (!m)
+ if (!m) {
+ if (c == '?') {
+ if (optopt) {
+ exit_error(
+ PARAMETER_PROBLEM,
+ "option `%s' "
+ "requires an "
+ "argument",
+ argv[optind-1]);
+ } else {
+ exit_error(
+ PARAMETER_PROBLEM,
+ "unknown option "
+ "`%s'",
+ argv[optind-1]);
+ }
+ }
exit_error(PARAMETER_PROBLEM,
"Unknown arg `%s'", optarg);
+ }
}
}
invert = FALSE;