diff options
| author | Giuseppe Longo <giuseppelng@gmail.com> | 2013-10-12 11:21:52 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2013-12-30 23:50:52 +0100 |
| commit | 0cfd537e8020812ef02ce0e27b8b22a94d3820c3 (patch) | |
| tree | 7fdef5b897f287c2178d7861d7bf08389a4dda18 /iptables/xtables-arp.c | |
| parent | 28dcf16384b223f9890567bd89056864a7e3c85d (diff) | |
nft: arp: fix possible string overflow
This patch replaces strcat with strncat and strcpy with strncpy
fixing possible string overflow.
Based on the original patch:
http://patchwork.ozlabs.org/patch/279672/
from Jaromír Končický via Jiri Popelka.
Signed-off-by: Giuseppe Longo <giuseppelng@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'iptables/xtables-arp.c')
| -rw-r--r-- | iptables/xtables-arp.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/iptables/xtables-arp.c b/iptables/xtables-arp.c index 411a6998..18f285c6 100644 --- a/iptables/xtables-arp.c +++ b/iptables/xtables-arp.c @@ -847,7 +847,8 @@ static struct xtables_target *command_jump(struct arpt_entry *fw, target->t = xtables_calloc(1, size); target->t->u.target_size = size; - strcpy(target->t->u.user.name, jumpto); + strncpy(target->t->u.user.name, jumpto, sizeof(target->t->u.user.name)); + target->t->u.user.name[sizeof(target->t->u.user.name)-1] = '\0'; target->t->u.user.revision = target->revision; xs_init_target(target); |