From 35b22e82fa62e10950d8e0fa53a755d4abadf346 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Tue, 5 Feb 2019 18:18:02 +0100 Subject: Revert "ebtables: use extrapositioned negation consistently" This reverts commit 5f508b76a0cebaf91965ffa678089222e2d47964. While attempts at unifying syntax between arp-, eb- and iptables-nft increase the opportunity for more code-sharing, they are problematic when it comes to compatibility. Accepting the old syntax on input helps, but due to the fact that neither arptables nor ebtables support --check command we must expect for users to test existence of a rule by comparing input with output. If that happens in a script, deviating from the old syntax in output has a high chance of breaking it. Therefore revert Florian's patch changing inversion character position in output and review the old code for consistency - the only thing changed on top of the actual revert is ebtables' own copy of print_iface() to make it adhere to the intrapositioned negation scheme used throughout ebtables. Added extension tests by the reverted commit have been kept. Signed-off-by: Phil Sutter Signed-off-by: Florian Westphal --- extensions/libebt_802_3.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'extensions/libebt_802_3.t') diff --git a/extensions/libebt_802_3.t b/extensions/libebt_802_3.t index 61081bd6..ddfb2f0a 100644 --- a/extensions/libebt_802_3.t +++ b/extensions/libebt_802_3.t @@ -1,3 +1,3 @@ :INPUT,FORWARD,OUTPUT -! --802_3-sap 0x0a -j CONTINUE;=;OK +--802_3-sap ! 0x0a -j CONTINUE;=;OK --802_3-type 0x000a -j RETURN;=;OK -- cgit v1.2.3