From 59e8114c6792242e80785f4461d5e663fb9a3d64 Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Mon, 15 Nov 2010 13:19:48 +0100 Subject: iptables: fix longopt reecognition and workaround getopt(3) behavior * On the first call to getopt, opts was NULL, so long options would not be recognized until a match/target was loaded. Whacky getopt behavior: * If the longopts parameter is NULL, getopt fails to recognize unknown options, such that `iptables-multi main --append` will print a garbage help message ("main needs an argument"). * If the longopts parameter is NULL on the first call, but not on subsequent calls, it completely screws up option parsing, taking the --dport in `iptables-multi main -A INPUT -p tcp --dport 1000` as --destination instead, but not accepting "--destination 1.2.3.4" either. Signed-off-by: Jan Engelhardt --- iptables.c | 1 + 1 file changed, 1 insertion(+) (limited to 'iptables.c') diff --git a/iptables.c b/iptables.c index 4c8bd773..c800fffd 100644 --- a/iptables.c +++ b/iptables.c @@ -147,6 +147,7 @@ void iptables_exit_error(enum xtables_exittype status, const char *msg, ...) __a struct xtables_globals iptables_globals = { .option_offset = 0, .program_version = IPTABLES_VERSION, + .opts = original_opts, .orig_opts = original_opts, .exit_err = iptables_exit_error, }; -- cgit v1.2.3