From af3d73ec867debb5e38c6c6fde66f05093714fec Mon Sep 17 00:00:00 2001 From: Jan Engelhardt Date: Fri, 11 Feb 2011 01:45:26 +0100 Subject: iptables: fix segfault target option parsing With v1.4.10-58-g94e247b, target option parsing started to happen in the wrong case. Signed-off-by: Jan Engelhardt --- iptables.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'iptables.c') diff --git a/iptables.c b/iptables.c index 33fd8822..a73df3ea 100644 --- a/iptables.c +++ b/iptables.c @@ -1269,9 +1269,9 @@ static void command_default(struct iptables_command_state *cs) struct xtables_rule_match *matchp; struct xtables_match *m; - if (cs->target == NULL || cs->target->parse == NULL || - cs->c < cs->target->option_offset || - cs->c >= cs->target->option_offset + XT_OPTION_OFFSET_SCALE) { + if (cs->target != NULL && cs->target->parse != NULL && + cs->c >= cs->target->option_offset && + cs->c < cs->target->option_offset + XT_OPTION_OFFSET_SCALE) { cs->target->parse(cs->c - cs->target->option_offset, cs->argv, cs->invert, &cs->target->tflags, &cs->fw, &cs->target->t); -- cgit v1.2.3