From 7e50ebabbf9c3a5eeb9511d9f32c6104b56da5cd Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Wed, 19 Sep 2018 15:17:04 +0200 Subject: Fix a few cases of pointless assignments This gets rid of a number of assignments which are either redundant or not used afterwards. Signed-off-by: Phil Sutter Signed-off-by: Florian Westphal --- iptables/iptables-xml.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'iptables/iptables-xml.c') diff --git a/iptables/iptables-xml.c b/iptables/iptables-xml.c index 788a67c6..07300efc 100644 --- a/iptables/iptables-xml.c +++ b/iptables/iptables-xml.c @@ -648,7 +648,6 @@ iptables_xml_main(int argc, char *argv[]) ret = 1; } else if (curTable[0]) { unsigned int a; - char *ptr = buffer; char *pcnt = NULL; char *bcnt = NULL; char *parsestart; @@ -661,7 +660,8 @@ iptables_xml_main(int argc, char *argv[]) if (buffer[0] == '[') { /* we have counters in our input */ - ptr = strchr(buffer, ']'); + char *ptr = strchr(buffer, ']'); + if (!ptr) xtables_error(PARAMETER_PROBLEM, "Bad line %u: need ]\n", -- cgit v1.2.3