From 6c266027bd84a03e54ef6182e2c97586f2d2821d Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Sun, 4 Apr 2010 16:32:51 +0200 Subject: remove bogus checking in mnl_attr_validate() and mnl_attr_validate2() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit attr.c: In function ‘mnl_attr_validate’: attr.c:189: warning: comparison of unsigned expression < 0 is always false attr.c: In function ‘mnl_attr_validate2’: attr.c:210: warning: comparison of unsigned expression < 0 is always false Signed-off-by: Pablo Neira Ayuso --- src/attr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/attr.c') diff --git a/src/attr.c b/src/attr.c index 75c856b..2ec6dce 100644 --- a/src/attr.c +++ b/src/attr.c @@ -186,7 +186,7 @@ int mnl_attr_validate(const struct nlattr *attr, enum mnl_attr_data_type type) { int exp_len; - if (type < 0 || type >= MNL_TYPE_MAX) { + if (type >= MNL_TYPE_MAX) { errno = EINVAL; return -1; } @@ -207,7 +207,7 @@ int mnl_attr_validate(const struct nlattr *attr, enum mnl_attr_data_type type) int mnl_attr_validate2(const struct nlattr *attr, enum mnl_attr_data_type type, int exp_len) { - if (type < 0 || type >= MNL_TYPE_MAX) { + if (type >= MNL_TYPE_MAX) { errno = EINVAL; return -1; } -- cgit v1.2.3