diff options
author | Pablo Neira Ayuso <pablo@netfilter.org> | 2008-12-10 22:50:23 +0100 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2008-12-10 22:50:23 +0100 |
commit | f44b2b59ec22903d98395a0543502551f9685e4d (patch) | |
tree | 7f16b4e093d9cb55151bc189054613eaeaffc4f4 /utils/conntrack_master.c | |
parent | 367324c4af8167a9384f23fb419b31b9cf960ac0 (diff) |
utils: fix wrong use of errno in example files
This patch removes the use of strerr(errno) when the returned
valued is != -1. This fixes random segfaults in my x86_64
machines. According to the documentation, errno should not be
used unless the returned value is -1.
This patch also includes some missing nfct_close() calls in
the examples.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'utils/conntrack_master.c')
-rw-r--r-- | utils/conntrack_master.c | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/utils/conntrack_master.c b/utils/conntrack_master.c index bdee474..1cd7490 100644 --- a/utils/conntrack_master.c +++ b/utils/conntrack_master.c @@ -39,7 +39,11 @@ int main() ret = nfct_query(h, NFCT_Q_CREATE, ct); - printf("TEST: create conntrack (%d)(%s)\n", ret, strerror(errno)); + printf("TEST: create conntrack "); + if (ret == -1) + printf("(%d)(%s)\n", ret, strerror(errno)); + else + printf("(OK)\n"); if (ret == -1) exit(EXIT_FAILURE); @@ -77,11 +81,13 @@ int main() ret = nfct_query(h, NFCT_Q_CREATE, ct); - printf("TEST: create confirmed conntrack (%d)(%s)\n", - ret, strerror(errno)); - + printf("TEST: create confirmed conntrack "); if (ret == -1) - exit(EXIT_FAILURE); + printf("(%d)(%s)\n", ret, strerror(errno)); + else + printf("(OK)\n"); nfct_close(h); + + ret == -1 ? exit(EXIT_FAILURE) : exit(EXIT_SUCCESS); } |