From 75c69a3da6ae268f42aecca7e5ae79dacdd87414 Mon Sep 17 00:00:00 2001 From: Jiri Popelka Date: Fri, 10 Jun 2011 11:12:15 +0200 Subject: conntrack: objopt: NO_EFFECT static analysis (analysis based only on compiling of sources, not based on running of binary) of the code revealed the following problem: conntrack/objopt.c:63: self_assign: Assignment operation "ct->snat.l4max.all = ct->snat.l4max.all" has no effect. Signed-off-by: Jiri Popelka Signed-off-by: Pablo Neira Ayuso --- src/conntrack/objopt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/conntrack/objopt.c') diff --git a/src/conntrack/objopt.c b/src/conntrack/objopt.c index 7e6e5e2..6180663 100644 --- a/src/conntrack/objopt.c +++ b/src/conntrack/objopt.c @@ -60,7 +60,7 @@ static void setobjopt_undo_dnat(struct nf_conntrack *ct) static void setobjopt_undo_spat(struct nf_conntrack *ct) { ct->snat.l4min.all = ct->tuple[__DIR_REPL].l4dst.tcp.port; - ct->snat.l4max.all = ct->snat.l4max.all; + ct->snat.l4max.all = ct->snat.l4min.all; ct->tuple[__DIR_REPL].l4dst.tcp.port = ct->tuple[__DIR_ORIG].l4src.tcp.port; set_bit(ATTR_SNAT_PORT, ct->set); -- cgit v1.2.3