diff options
author | David Fabro <netfilter@meta-dynamic.com> | 2010-06-10 15:03:44 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2010-06-10 15:03:44 +0200 |
commit | 21fd1834b5ce0a1f5b590f7e1ad23bba64fbafdf (patch) | |
tree | 638d843052af388d42bdbd9419ed36c10f4c5b66 /src/libnetfilter_queue.c | |
parent | 6e204c91b6c7ece751331de2fa3fb460bc5edd59 (diff) |
payload buffer datatypes are consistent
The 'data' parameter to nfq_get_payload() returns pointer to unsigned
char (rather than signed char) to make it consistent with the 'buf'
parameter of nfq_set_verdict(), nfq_set_verdict2(), and
nfq_set_verdict_mark(), all of which refer to the same data. Either
signed or unsigned is fine, but they should be consistent as the output
of nfq_get_payload() may be passed back into nfq_set_verdict*(); in that
case, this change eliminates the need for typecasting in the calling
code when using compilers that enforce strict typecasting.
Signed-off-by: David Favro <netfilter@meta-dynamic.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/libnetfilter_queue.c')
-rw-r--r-- | src/libnetfilter_queue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/libnetfilter_queue.c b/src/libnetfilter_queue.c index 4cc4925..c543055 100644 --- a/src/libnetfilter_queue.c +++ b/src/libnetfilter_queue.c @@ -1003,7 +1003,7 @@ struct nfqnl_msg_packet_hw *nfq_get_packet_hw(struct nfq_data *nfad) * * \return -1 on error, otherwise > 0. */ -int nfq_get_payload(struct nfq_data *nfad, char **data) +int nfq_get_payload(struct nfq_data *nfad, unsigned char **data) { *data = nfnl_get_pointer_to_data(nfad->data, NFQA_PAYLOAD, char); if (*data) |