summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPablo Neira Ayuso <pablo@netfilter.org>2014-02-03 12:09:29 +0100
committerPablo Neira Ayuso <pablo@netfilter.org>2014-02-03 12:09:29 +0100
commit7633f0c1679988ad18e4de9afc8a277510298139 (patch)
treeee935a1742e4cb9600007baa431c0365e48bca1d /src
parent94b68f36a09745a51ff47c1cbfef8ae17c8eff92 (diff)
libnfnetlink: initialize attribute padding to resolve valgrind warnings
==12195== Syscall param socketcall.sendto(msg) points to uninitialised byte(s) ==12195== at 0x51209C3: __sendto_nocancel (syscall-template.S:81) ==12195== by 0x53E4D12: nfnl_send (libnfnetlink.c:391) ==12195== by 0x53E6952: nfnl_query (libnfnetlink.c:1569) ==12195== by 0x4E344AF: __build_send_cfg_msg.isra.1 (libnetfilter_log.c:143) ==12195== by 0x4E34710: nflog_bind_group (libnetfilter_log.c:413) ==12195== by 0x400CB1: main (nfulnl_test.c:77) ==12195== Address 0x7fefff3e9 is on thread 1's stack This patch sets to zero the padding that is included to align the attribute payload. Reported-by: Ivan Homoliak <xhomol11@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src')
-rw-r--r--src/libnfnetlink.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libnfnetlink.c b/src/libnfnetlink.c
index 4b2bcd0..398b7d7 100644
--- a/src/libnfnetlink.c
+++ b/src/libnfnetlink.c
@@ -809,6 +809,7 @@ int nfnl_addattr_l(struct nlmsghdr *n, int maxlen, int type, const void *data,
nfa->nfa_type = type;
nfa->nfa_len = len;
memcpy(NFA_DATA(nfa), data, alen);
+ memset((uint8_t *)nfa + nfa->nfa_len, 0, NFA_ALIGN(alen) - alen);
n->nlmsg_len = (NLMSG_ALIGN(n->nlmsg_len) + NFA_ALIGN(len));
return 0;
}