From 4248314d4018739ba3d9a5b2b7b82097a1298a5b Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Mon, 13 Aug 2012 19:54:54 +0200 Subject: nfnl: fix compilation warning with gcc-4.7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit libnfnetlink.c: In function ‘nfnl_open’: libnfnetlink.c:177:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] The getsockname value was not checked before. Better to check for errors, but I prefer not to modify this behaviour. This library will enter EOL once all netfilter libraries are fully ported to libmnl. Signed-off-by: Pablo Neira Ayuso --- src/libnfnetlink.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/libnfnetlink.c b/src/libnfnetlink.c index 86cc94c..4b2bcd0 100644 --- a/src/libnfnetlink.c +++ b/src/libnfnetlink.c @@ -174,7 +174,6 @@ struct nfnl_handle *nfnl_open(void) { struct nfnl_handle *nfnlh; unsigned int addr_len; - int err; nfnlh = malloc(sizeof(*nfnlh)); if (!nfnlh) @@ -189,8 +188,7 @@ struct nfnl_handle *nfnl_open(void) nfnlh->peer.nl_family = AF_NETLINK; addr_len = sizeof(nfnlh->local); - err = getsockname(nfnlh->fd, (struct sockaddr *)&nfnlh->local, - &addr_len); + getsockname(nfnlh->fd, (struct sockaddr *)&nfnlh->local, &addr_len); if (addr_len != sizeof(nfnlh->local)) { errno = EINVAL; goto err_close; @@ -211,8 +209,7 @@ struct nfnl_handle *nfnl_open(void) /* use getsockname to get the netlink pid that the kernel assigned us */ addr_len = sizeof(nfnlh->local); - err = getsockname(nfnlh->fd, (struct sockaddr *)&nfnlh->local, - &addr_len); + getsockname(nfnlh->fd, (struct sockaddr *)&nfnlh->local, &addr_len); if (addr_len != sizeof(nfnlh->local)) { errno = EINVAL; goto err_close; -- cgit v1.2.3