diff options
author | Phil Sutter <phil@nwl.cc> | 2021-03-09 11:26:47 +0100 |
---|---|---|
committer | Phil Sutter <phil@nwl.cc> | 2021-03-15 12:23:20 +0100 |
commit | 960c8e6174374ee113b290c304365bf02ed346d6 (patch) | |
tree | 3c5b27821e29409822920e6113e1c3364ac5b4e9 /src/expr.c | |
parent | 4f6e671b462180ba9af12bd30211811b5fca8cb1 (diff) |
Drop pointless local variable in snprintf callbacks
A common idiom among snprintf callbacks was to copy the unsigned
parameter 'size' (or 'len') into a signed variable for further use.
Though since snprintf() itself casts it to unsigned and
SNPRINTF_BUFFER_SIZE() does not allow it to become negative, this is not
needed. Drop the local variable and rename the parameter accordingly.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Diffstat (limited to 'src/expr.c')
-rw-r--r-- | src/expr.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -270,13 +270,13 @@ err1: } EXPORT_SYMBOL(nftnl_expr_snprintf); -int nftnl_expr_snprintf(char *buf, size_t size, const struct nftnl_expr *expr, +int nftnl_expr_snprintf(char *buf, size_t remain, const struct nftnl_expr *expr, uint32_t type, uint32_t flags) { int ret; - unsigned int offset = 0, remain = size; + unsigned int offset = 0; - if (size) + if (remain) buf[0] = '\0'; if (!expr->ops->snprintf || type != NFTNL_OUTPUT_DEFAULT) |