diff options
author | Pablo Neira Ayuso <pablo@netfilter.org> | 2014-07-20 14:09:34 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2014-07-20 15:04:47 +0200 |
commit | 367cbfaae87c1f539c729b0653d920701beac3be (patch) | |
tree | 232077cd854cc757784383b56abcde8383b006dd /src/expr/immediate.c | |
parent | cac9b26874d60aa17c7cabe46d33e9114b24885d (diff) |
src: stricter netlink attribute length validation
If the kernel sends us different data length for a given attribute,
stop further processing and indicate that an ABI breakage has ocurred.
This is an example of the (hypothetical) message that is shown in that
case:
nf_tables kernel ABI is broken, contact your vendor.
table.c:214 reason: Numerical result out of range
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/expr/immediate.c')
-rw-r--r-- | src/expr/immediate.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/expr/immediate.c b/src/expr/immediate.c index 385ee61..5f54129 100644 --- a/src/expr/immediate.c +++ b/src/expr/immediate.c @@ -89,16 +89,12 @@ static int nft_rule_expr_immediate_cb(const struct nlattr *attr, void *data) switch(type) { case NFTA_IMMEDIATE_DREG: - if (mnl_attr_validate(attr, MNL_TYPE_U32) < 0) { - perror("mnl_attr_validate"); - return MNL_CB_ERROR; - } + if (mnl_attr_validate(attr, MNL_TYPE_U32) < 0) + abi_breakage(); break; case NFTA_IMMEDIATE_DATA: - if (mnl_attr_validate(attr, MNL_TYPE_BINARY) < 0) { - perror("mnl_attr_validate"); - return MNL_CB_ERROR; - } + if (mnl_attr_validate(attr, MNL_TYPE_BINARY) < 0) + abi_breakage(); break; } |