src: simplify getter logic

This patch refactors the getter code to simplify it. The default
cases have been removed so gcc will spot a warning if an attribute
is not handled appropriately.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

1 files changed, 6 insertions, 20 deletions

diff --git a/src/expr/target.c b/src/expr/target.c
index d9d9daf..6365a46 100644
--- a/src/expr/target.c
+++ b/src/expr/target.c
@@ -69,28 +69,14 @@ nft_rule_expr_target_get(const struct nft_rule_expr *e, uint16_t type,
 
 	switch(type) {
 	case NFT_EXPR_TG_NAME:
-		if (e->flags & (1 << NFT_EXPR_TG_NAME)) {
-			*data_len = sizeof(tg->name);
-			return tg->name;
-		} else
-			return NULL;
-		break;
+		*data_len = sizeof(tg->name);
+		return tg->name;
 	case NFT_EXPR_TG_REV:
-		if (e->flags & (1 << NFT_EXPR_TG_REV)) {
-			*data_len = sizeof(tg->rev);
-			return &tg->rev;
-		} else
-			return NULL;
-		break;
+		*data_len = sizeof(tg->rev);
+		return &tg->rev;
 	case NFT_EXPR_TG_INFO:
-		if (e->flags & (1 << NFT_EXPR_TG_INFO)) {
-			*data_len = tg->data_len;
-			return tg->data;
-		} else
-			return NULL;
-		break;
-	default:
-		break;
+		*data_len = tg->data_len;
+		return tg->data;
 	}
 	return NULL;
 }