diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2013-07-25 21:21:51 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2013-07-25 21:31:35 +0200 |
| commit | 3f994836f6bb124a5c0185ab6659ef7f57ceac5f (patch) | |
| tree | 42e568f80d1d47c5e01b1367e58a494c5dfa446e /src/expr/target.c | |
| parent | 1c86a5f0f9df07b66691115ba4b0a9ee0f978dd6 (diff) | |
src: xml: consolidate common XML code via nft_mxml_str_parse
This patch moves common XML string parsing code to nft_mxml_str_parse().
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/expr/target.c')
| -rw-r--r-- | src/expr/target.c | 20 |
1 files changed, 9 insertions, 11 deletions
diff --git a/src/expr/target.c b/src/expr/target.c index 6365a46..e59f86a 100644 --- a/src/expr/target.c +++ b/src/expr/target.c @@ -175,17 +175,15 @@ nft_rule_expr_target_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree) { #ifdef XML_PARSING struct nft_expr_target *tg = nft_expr_data(e); - mxml_node_t *node = NULL; - - /* Get and set <name>. Optional */ - node = mxmlFindElement(tree, tree, "name", NULL, NULL, - MXML_DESCEND_FIRST); - if (node != NULL) { - memcpy(tg->name, node->child->value.opaque, - XT_EXTENSION_MAXNAMELEN); - tg->name[XT_EXTENSION_MAXNAMELEN-1] = '\0'; - e->flags |= (1 << NFT_EXPR_TG_NAME); - } + const char *name; + + name = nft_mxml_str_parse(tree, "name", MXML_DESCEND_FIRST); + if (name == NULL) + return -1; + + strncpy(tg->name, name, XT_EXTENSION_MAXNAMELEN); + tg->name[XT_EXTENSION_MAXNAMELEN-1] = '\0'; + e->flags |= (1 << NFT_EXPR_TG_NAME); /* tg->info is ignored until other solution is reached */ |