summaryrefslogtreecommitdiffstats
path: root/src/expr
diff options
context:
space:
mode:
authorAna Rey <anarey@gmail.com>2014-06-23 11:38:18 +0200
committerPablo Neira Ayuso <pablo@netfilter.org>2014-06-23 19:48:09 +0200
commitdccedc04051e246d6a553c35c280f2bf9e2e8fd1 (patch)
tree664f43d540220f0a2965a09598ff05729dd3b288 /src/expr
parent9d62d929ef4a2d2a55e22ffee5c04ed8ba2d2856 (diff)
expr: target: Use nft_rule_expr_set_* in the xml parsing code
Code refactoring to use nft_rule_expr_set_* in parse functions Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/expr')
-rw-r--r--src/expr/target.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/expr/target.c b/src/expr/target.c
index 5245ff7..623d22c 100644
--- a/src/expr/target.c
+++ b/src/expr/target.c
@@ -195,7 +195,6 @@ nft_rule_expr_target_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
struct nft_parse_err *err)
{
#ifdef XML_PARSING
- struct nft_expr_target *tg = nft_expr_data(e);
const char *name;
name = nft_mxml_str_parse(tree, "name", MXML_DESCEND_FIRST,
@@ -203,9 +202,7 @@ nft_rule_expr_target_xml_parse(struct nft_rule_expr *e, mxml_node_t *tree,
if (name == NULL)
return -1;
- strncpy(tg->name, name, XT_EXTENSION_MAXNAMELEN);
- tg->name[XT_EXTENSION_MAXNAMELEN-1] = '\0';
- e->flags |= (1 << NFT_EXPR_TG_NAME);
+ nft_rule_expr_set_str(e, NFT_EXPR_TG_NAME, name);
/* tg->info is ignored until other solution is reached */