src: xml: don't duplicate string in nft_table_xml_parse

With this patch, nft_table_xml_parse does not duplicate the string
anymore, which is what most callers seem to need. This fixes memleaks
in several places in the code. Thus, this patch also adapts the code
to duplicate it when needed.

Based on patch from Arturo Borrero.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

1 files changed, 1 insertions, 3 deletions

diff --git a/src/mxml.c b/src/mxml.c
index b5de153..b77936a 100644
--- a/src/mxml.c
+++ b/src/mxml.c
@@ -163,7 +163,7 @@ const char *nft_mxml_str_parse(mxml_node_t *tree, const char *node_name,
 		return NULL;
 	}
 
-	return strdup(node->child->value.opaque);
+	return node->child->value.opaque;
 }
 
 int nft_mxml_family_parse(mxml_node_t *tree, const char *node_name,
@@ -177,8 +177,6 @@ int nft_mxml_family_parse(mxml_node_t *tree, const char *node_name,
 		return -1;
 
 	family = nft_str2family(family_str);
-	xfree(family_str);
-
 	if (family < 0)
 		errno = EAFNOSUPPORT;