diff options
author | Arturo Borrero <arturo.borrero.glez@gmail.com> | 2014-02-26 19:13:26 +0100 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2014-02-27 10:35:08 +0100 |
commit | cfe671fa741c9669cadc5dfbf9ae63eb440601cf (patch) | |
tree | eadb2e1a0242a4a49808327efa1e05bc19f8726f /src/set.c | |
parent | 313c702ad8700ee5a959d81fd5b2da38e161c278 (diff) |
src: check if netlink parsing fails
We have to check if mnl_attr_parse() returns an error, which means that it
failed to validate and retrieve the attributes.
Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src/set.c')
-rw-r--r-- | src/set.c | 7 |
1 files changed, 4 insertions, 3 deletions
@@ -281,9 +281,10 @@ int nft_set_nlmsg_parse(const struct nlmsghdr *nlh, struct nft_set *s) { struct nlattr *tb[NFTA_SET_MAX+1] = {}; struct nfgenmsg *nfg = mnl_nlmsg_get_payload(nlh); - int ret = 0; - mnl_attr_parse(nlh, sizeof(*nfg), nft_set_parse_attr_cb, tb); + if (mnl_attr_parse(nlh, sizeof(*nfg), nft_set_parse_attr_cb, tb) < 0) + return -1; + if (tb[NFTA_SET_TABLE]) { s->table = strdup(mnl_attr_get_str(tb[NFTA_SET_TABLE])); s->flags |= (1 << NFT_SET_ATTR_TABLE); @@ -315,7 +316,7 @@ int nft_set_nlmsg_parse(const struct nlmsghdr *nlh, struct nft_set *s) s->family = nfg->nfgen_family; s->flags |= (1 << NFT_SET_ATTR_FAMILY); - return ret; + return 0; } EXPORT_SYMBOL(nft_set_nlmsg_parse); |