diff options
author | Phil Sutter <phil@nwl.cc> | 2019-10-30 18:31:59 +0100 |
---|---|---|
committer | Phil Sutter <phil@nwl.cc> | 2019-10-31 14:57:08 +0100 |
commit | 7349a70634fa02838aea33be0ff1b5491ac8dee9 (patch) | |
tree | c73d2368cc72cfca021f89d0c143daa869604d93 /src | |
parent | 3c1a1779cb0d2725521e8411903d37b1aebd956c (diff) |
Deprecate untyped data setters
These functions make assumptions on size of passed data pointer and
therefore tend to hide programming mistakes. Instead either one of the
type-specific setters or the generic *_set_data() setter should be used.
Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src')
-rw-r--r-- | src/chain.c | 2 | ||||
-rw-r--r-- | src/flowtable.c | 2 | ||||
-rw-r--r-- | src/gen.c | 2 | ||||
-rw-r--r-- | src/object.c | 2 | ||||
-rw-r--r-- | src/rule.c | 2 | ||||
-rw-r--r-- | src/set.c | 2 | ||||
-rw-r--r-- | src/table.c | 2 |
7 files changed, 7 insertions, 7 deletions
diff --git a/src/chain.c b/src/chain.c index 84e5414..d4050d2 100644 --- a/src/chain.c +++ b/src/chain.c @@ -284,7 +284,7 @@ int nftnl_chain_set_data(struct nftnl_chain *c, uint16_t attr, return 0; } -EXPORT_SYMBOL(nftnl_chain_set); +void nftnl_chain_set(struct nftnl_chain *c, uint16_t attr, const void *data) __visible; void nftnl_chain_set(struct nftnl_chain *c, uint16_t attr, const void *data) { nftnl_chain_set_data(c, attr, data, nftnl_chain_validate[attr]); diff --git a/src/flowtable.c b/src/flowtable.c index f9101e8..ed91357 100644 --- a/src/flowtable.c +++ b/src/flowtable.c @@ -171,7 +171,7 @@ int nftnl_flowtable_set_data(struct nftnl_flowtable *c, uint16_t attr, return 0; } -EXPORT_SYMBOL(nftnl_flowtable_set); +void nftnl_flowtable_set(struct nftnl_flowtable *c, uint16_t attr, const void *data) __visible; void nftnl_flowtable_set(struct nftnl_flowtable *c, uint16_t attr, const void *data) { nftnl_flowtable_set_data(c, attr, data, nftnl_flowtable_validate[attr]); @@ -80,7 +80,7 @@ int nftnl_gen_set_data(struct nftnl_gen *gen, uint16_t attr, return 0; } -EXPORT_SYMBOL(nftnl_gen_set); +int nftnl_gen_set(struct nftnl_gen *gen, uint16_t attr, const void *data) __visible; int nftnl_gen_set(struct nftnl_gen *gen, uint16_t attr, const void *data) { return nftnl_gen_set_data(gen, attr, data, nftnl_gen_validate[attr]); diff --git a/src/object.c b/src/object.c index ed8e36d..c876add 100644 --- a/src/object.c +++ b/src/object.c @@ -112,7 +112,7 @@ void nftnl_obj_set_data(struct nftnl_obj *obj, uint16_t attr, obj->flags |= (1 << attr); } -EXPORT_SYMBOL(nftnl_obj_set); +void nftnl_obj_set(struct nftnl_obj *obj, uint16_t attr, const void *data) __visible; void nftnl_obj_set(struct nftnl_obj *obj, uint16_t attr, const void *data) { nftnl_obj_set_data(obj, attr, data, nftnl_obj_validate[attr]); @@ -168,7 +168,7 @@ int nftnl_rule_set_data(struct nftnl_rule *r, uint16_t attr, return 0; } -EXPORT_SYMBOL(nftnl_rule_set); +int nftnl_rule_set(struct nftnl_rule *r, uint16_t attr, const void *data) __visible; int nftnl_rule_set(struct nftnl_rule *r, uint16_t attr, const void *data) { return nftnl_rule_set_data(r, attr, data, nftnl_rule_validate[attr]); @@ -195,7 +195,7 @@ int nftnl_set_set_data(struct nftnl_set *s, uint16_t attr, const void *data, return 0; } -EXPORT_SYMBOL(nftnl_set_set); +int nftnl_set_set(struct nftnl_set *s, uint16_t attr, const void *data) __visible; int nftnl_set_set(struct nftnl_set *s, uint16_t attr, const void *data) { return nftnl_set_set_data(s, attr, data, nftnl_set_validate[attr]); diff --git a/src/table.c b/src/table.c index 54259ee..adcfafe 100644 --- a/src/table.c +++ b/src/table.c @@ -117,7 +117,7 @@ int nftnl_table_set_data(struct nftnl_table *t, uint16_t attr, return 0; } -EXPORT_SYMBOL(nftnl_table_set); +void nftnl_table_set(struct nftnl_table *t, uint16_t attr, const void *data) __visible; void nftnl_table_set(struct nftnl_table *t, uint16_t attr, const void *data) { nftnl_table_set_data(t, attr, data, nftnl_table_validate[attr]); |