summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPhil Sutter <phil@nwl.cc>2017-12-14 20:40:20 +0100
committerPablo Neira Ayuso <pablo@netfilter.org>2017-12-15 16:22:12 +0100
commit4177002b26f025891cc509b54dc76bcf98f1c35f (patch)
tree9d0c560827d3b4277a0f561f217d36277e960f1e /src
parent3dc1c825d76b678620a13f4f446d384badad5670 (diff)
data_reg: Add a missing break in nftnl_data_reg_snprintf
The code works fine as-is, but if reg_type == DATA_VALUE && output_format == NFTNL_OUTPUT_XML, we fall through to DATA_CHAIN case and therefore pointlessly check output_format again. Signed-off-by: Phil Sutter <phil@nwl.cc> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src')
-rw-r--r--src/expr/data_reg.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c
index a246952..7023202 100644
--- a/src/expr/data_reg.c
+++ b/src/expr/data_reg.c
@@ -207,6 +207,7 @@ int nftnl_data_reg_snprintf(char *buf, size_t size,
default:
break;
}
+ break;
case DATA_VERDICT:
case DATA_CHAIN:
switch(output_format) {
@@ -220,6 +221,7 @@ int nftnl_data_reg_snprintf(char *buf, size_t size,
default:
break;
}
+ break;
default:
break;
}