From 6dc1c3d8bb64077da7f3f28c7368fb087d10a492 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Wed, 24 Oct 2018 19:18:50 +0200 Subject: src: remove nftnl_rule_cmp() and nftnl_expr_cmp() These functions are not very useful, rule comparison from this layer does not work well with implicit set definitions. This infrastructure was added as an attempt to support for deletion by name from this layer, which should be done from higher level libnftables library. Finally, we never had a client for this code in git.netfilter.org. Let's remove it and bump libversion for safety reasons. Signed-off-by: Pablo Neira Ayuso --- src/expr.c | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'src/expr.c') diff --git a/src/expr.c b/src/expr.c index 62565e0..80c4c36 100644 --- a/src/expr.c +++ b/src/expr.c @@ -203,16 +203,6 @@ const char *nftnl_expr_get_str(const struct nftnl_expr *expr, uint16_t type) return (const char *)nftnl_expr_get(expr, type, &data_len); } -EXPORT_SYMBOL(nftnl_expr_cmp); -bool nftnl_expr_cmp(const struct nftnl_expr *e1, const struct nftnl_expr *e2) -{ - if (e1->flags != e2->flags || - strcmp(e1->ops->name, e2->ops->name) != 0) - return false; - - return e1->ops->cmp(e1, e2); -} - void nftnl_expr_build_payload(struct nlmsghdr *nlh, struct nftnl_expr *expr) { struct nlattr *nest; -- cgit v1.2.3