From 783a972f6acd680bed92fac36c5388d15620e754 Mon Sep 17 00:00:00 2001 From: Arturo Borrero Gonzalez Date: Wed, 26 Jun 2013 13:37:02 +0200 Subject: expr: xml: registers must be <= NFT_REG_MAX With this patch, all expressions validate that registers are <= NFT_REG_MAX. Signed-off-by: Arturo Borrero Gonzalez Signed-off-by: Pablo Neira Ayuso --- src/expr/byteorder.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/expr/byteorder.c') diff --git a/src/expr/byteorder.c b/src/expr/byteorder.c index 201a943..c2f38a8 100644 --- a/src/expr/byteorder.c +++ b/src/expr/byteorder.c @@ -225,6 +225,9 @@ nft_rule_expr_byteorder_xml_parse(struct nft_rule_expr *e, char *xml) if (tmp > UINT32_MAX || tmp < 0 || *endptr) goto err; + if (tmp > NFT_REG_MAX) + goto err; + byteorder->sreg = tmp; e->flags |= (1 << NFT_EXPR_BYTEORDER_SREG); @@ -236,6 +239,9 @@ nft_rule_expr_byteorder_xml_parse(struct nft_rule_expr *e, char *xml) if (tmp > UINT32_MAX || tmp < 0 || *endptr) goto err; + if (tmp > NFT_REG_MAX) + goto err; + byteorder->dreg = tmp; e->flags |= (1 << NFT_EXPR_BYTEORDER_DREG); -- cgit v1.2.3