From 783a972f6acd680bed92fac36c5388d15620e754 Mon Sep 17 00:00:00 2001 From: Arturo Borrero Gonzalez Date: Wed, 26 Jun 2013 13:37:02 +0200 Subject: expr: xml: registers must be <= NFT_REG_MAX With this patch, all expressions validate that registers are <= NFT_REG_MAX. Signed-off-by: Arturo Borrero Gonzalez Signed-off-by: Pablo Neira Ayuso --- src/expr/cmp.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/expr/cmp.c') diff --git a/src/expr/cmp.c b/src/expr/cmp.c index dac1f54..9507a0e 100644 --- a/src/expr/cmp.c +++ b/src/expr/cmp.c @@ -203,6 +203,11 @@ static int nft_rule_expr_cmp_xml_parse(struct nft_rule_expr *e, char *xml) return -1; } + if (tmp > NFT_REG_MAX) { + mxmlDelete(tree); + return -1; + } + cmp->sreg = (uint8_t)tmp; e->flags |= (1 << NFT_EXPR_CMP_SREG); } -- cgit v1.2.3