From 6dc1c3d8bb64077da7f3f28c7368fb087d10a492 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Wed, 24 Oct 2018 19:18:50 +0200 Subject: src: remove nftnl_rule_cmp() and nftnl_expr_cmp() These functions are not very useful, rule comparison from this layer does not work well with implicit set definitions. This infrastructure was added as an attempt to support for deletion by name from this layer, which should be done from higher level libnftables library. Finally, we never had a client for this code in git.netfilter.org. Let's remove it and bump libversion for safety reasons. Signed-off-by: Pablo Neira Ayuso --- src/expr/data_reg.c | 17 ----------------- 1 file changed, 17 deletions(-) (limited to 'src/expr/data_reg.c') diff --git a/src/expr/data_reg.c b/src/expr/data_reg.c index 48a012b..67165fe 100644 --- a/src/expr/data_reg.c +++ b/src/expr/data_reg.c @@ -93,23 +93,6 @@ int nftnl_data_reg_snprintf(char *buf, size_t size, return -1; } -bool nftnl_data_reg_cmp(const union nftnl_data_reg *r1, - const union nftnl_data_reg *r2, int reg_type) -{ - switch (reg_type) { - case DATA_VALUE: - return r1->len == r2->len && - !memcmp(r1->val, r2->val, r1->len); - case DATA_VERDICT: - return r1->verdict == r2->verdict; - case DATA_CHAIN: - return r1->verdict == r2->verdict && - !strcmp(r1->chain, r2->chain); - default: - return false; - } -} - static int nftnl_data_parse_cb(const struct nlattr *attr, void *data) { const struct nlattr **tb = data; -- cgit v1.2.3