From be0bae0ad31b0adb506f96de083f52a2bd0d4fbf Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Thu, 7 Mar 2024 14:49:08 +0100 Subject: expr: Respect data_len when setting attributes With attr_policy in place, data_len has an upper boundary but it may be lower than the attribute's storage area in which case memcpy() would read garbage. Signed-off-by: Phil Sutter --- src/expr/inner.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/expr/inner.c') diff --git a/src/expr/inner.c b/src/expr/inner.c index 45ef4fb..4f66e94 100644 --- a/src/expr/inner.c +++ b/src/expr/inner.c @@ -45,13 +45,13 @@ nftnl_expr_inner_set(struct nftnl_expr *e, uint16_t type, switch(type) { case NFTNL_EXPR_INNER_TYPE: - memcpy(&inner->type, data, sizeof(inner->type)); + memcpy(&inner->type, data, data_len); break; case NFTNL_EXPR_INNER_FLAGS: - memcpy(&inner->flags, data, sizeof(inner->flags)); + memcpy(&inner->flags, data, data_len); break; case NFTNL_EXPR_INNER_HDRSIZE: - memcpy(&inner->hdrsize, data, sizeof(inner->hdrsize)); + memcpy(&inner->hdrsize, data, data_len); break; case NFTNL_EXPR_INNER_EXPR: if (inner->expr) -- cgit v1.2.3