From 6cdc49ffbe0a672c27f4fffe831563b12a8e2e61 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Thu, 18 Jul 2013 20:01:27 +0200 Subject: src: simplify getter logic This patch refactors the getter code to simplify it. The default cases have been removed so gcc will spot a warning if an attribute is not handled appropriately. Signed-off-by: Pablo Neira Ayuso --- src/expr/log.c | 26 ++++---------------------- 1 file changed, 4 insertions(+), 22 deletions(-) (limited to 'src/expr/log.c') diff --git a/src/expr/log.c b/src/expr/log.c index b2c39c1..1ffd1d9 100644 --- a/src/expr/log.c +++ b/src/expr/log.c @@ -65,31 +65,13 @@ nft_rule_expr_log_get(const struct nft_rule_expr *e, uint16_t type, switch(type) { case NFT_EXPR_LOG_PREFIX: - if (e->flags & (1 << NFT_EXPR_LOG_PREFIX)) - return log->prefix; - else - return NULL; - break; + return log->prefix; case NFT_EXPR_LOG_GROUP: - if (e->flags & (1 << NFT_EXPR_LOG_GROUP)) - return &log->group; - else - return NULL; - break; + return &log->group; case NFT_EXPR_LOG_SNAPLEN: - if (e->flags & (1 << NFT_EXPR_LOG_SNAPLEN)) - return &log->snaplen; - else - return NULL; - break; + return &log->snaplen; case NFT_EXPR_LOG_QTHRESHOLD: - if (e->flags & (1 << NFT_EXPR_LOG_QTHRESHOLD)) - return &log->qthreshold; - else - return NULL; - break; - default: - break; + return &log->qthreshold; } return NULL; } -- cgit v1.2.3