From 783a972f6acd680bed92fac36c5388d15620e754 Mon Sep 17 00:00:00 2001 From: Arturo Borrero Gonzalez Date: Wed, 26 Jun 2013 13:37:02 +0200 Subject: expr: xml: registers must be <= NFT_REG_MAX With this patch, all expressions validate that registers are <= NFT_REG_MAX. Signed-off-by: Arturo Borrero Gonzalez Signed-off-by: Pablo Neira Ayuso --- src/expr/lookup.c | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'src/expr/lookup.c') diff --git a/src/expr/lookup.c b/src/expr/lookup.c index 0ae93ce..ecc07cb 100644 --- a/src/expr/lookup.c +++ b/src/expr/lookup.c @@ -204,6 +204,11 @@ nft_rule_expr_lookup_xml_parse(struct nft_rule_expr *e, char *xml) return -1; } + if (tmp > NFT_REG_MAX) { + mxmlDelete(tree); + return -1; + } + lookup->sreg = (uint32_t)tmp; e->flags |= (1 << NFT_EXPR_LOOKUP_SREG); @@ -217,6 +222,11 @@ nft_rule_expr_lookup_xml_parse(struct nft_rule_expr *e, char *xml) return -1; } + if (tmp > NFT_REG_MAX) { + mxmlDelete(tree); + return -1; + } + lookup->dreg = (uint32_t)tmp; e->flags |= (1 << NFT_EXPR_LOOKUP_DREG); } -- cgit v1.2.3