From c48ac8cba8716a8bc4ff713ee965eee2643cfc31 Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Thu, 7 Mar 2024 14:34:18 +0100 Subject: obj: Respect data_len when setting attributes With attr_policy in place, data_len has an upper boundary. Use it for memcpy() calls to cover for caller passing data with lower size than the attribute's storage. Signed-off-by: Phil Sutter --- src/obj/ct_timeout.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/obj/ct_timeout.c') diff --git a/src/obj/ct_timeout.c b/src/obj/ct_timeout.c index 88522d8..b9b688e 100644 --- a/src/obj/ct_timeout.c +++ b/src/obj/ct_timeout.c @@ -150,10 +150,10 @@ static int nftnl_obj_ct_timeout_set(struct nftnl_obj *e, uint16_t type, switch (type) { case NFTNL_OBJ_CT_TIMEOUT_L3PROTO: - memcpy(&timeout->l3proto, data, sizeof(timeout->l3proto)); + memcpy(&timeout->l3proto, data, data_len); break; case NFTNL_OBJ_CT_TIMEOUT_L4PROTO: - memcpy(&timeout->l4proto, data, sizeof(timeout->l4proto)); + memcpy(&timeout->l4proto, data, data_len); break; case NFTNL_OBJ_CT_TIMEOUT_ARRAY: if (data_len < sizeof(uint32_t) * NFTNL_CTTIMEOUT_ARRAY_MAX) -- cgit v1.2.3