From 7a150cacc1754f66525f0e87b14b35fbc2a6338e Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Fri, 12 Aug 2016 01:33:38 +0200 Subject: src: Avoid returning uninitialized data Although the 'err' pointer should be interesting for users only if the parser returned non-zero, having it point to uninitialized data is generally a bad thing. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- src/chain.c | 2 +- src/rule.c | 2 +- src/set.c | 2 +- src/table.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/chain.c b/src/chain.c index ff59f7f..dfe0cf2 100644 --- a/src/chain.c +++ b/src/chain.c @@ -816,7 +816,7 @@ static int nftnl_chain_do_parse(struct nftnl_chain *c, enum nftnl_parse_type typ enum nftnl_parse_input input) { int ret; - struct nftnl_parse_err perr; + struct nftnl_parse_err perr = {}; switch (type) { case NFTNL_PARSE_XML: diff --git a/src/rule.c b/src/rule.c index dada00e..8aeefbe 100644 --- a/src/rule.c +++ b/src/rule.c @@ -700,7 +700,7 @@ static int nftnl_rule_do_parse(struct nftnl_rule *r, enum nftnl_parse_type type, enum nftnl_parse_input input) { int ret; - struct nftnl_parse_err perr; + struct nftnl_parse_err perr = {}; switch (type) { case NFTNL_PARSE_XML: diff --git a/src/set.c b/src/set.c index 7a41e8c..47b6ef4 100644 --- a/src/set.c +++ b/src/set.c @@ -781,7 +781,7 @@ static int nftnl_set_do_parse(struct nftnl_set *s, enum nftnl_parse_type type, enum nftnl_parse_input input) { int ret; - struct nftnl_parse_err perr; + struct nftnl_parse_err perr = {}; switch (type) { case NFTNL_PARSE_XML: diff --git a/src/table.c b/src/table.c index bb46716..845fd68 100644 --- a/src/table.c +++ b/src/table.c @@ -360,7 +360,7 @@ static int nftnl_table_do_parse(struct nftnl_table *t, enum nftnl_parse_type typ enum nftnl_parse_input input) { int ret; - struct nftnl_parse_err perr; + struct nftnl_parse_err perr = {}; switch (type) { case NFTNL_PARSE_XML: -- cgit v1.2.3