From b58cf8947422ba695df80fe3b012b383fff22f7a Mon Sep 17 00:00:00 2001
From: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Date: Tue, 6 Aug 2013 10:40:33 +0200
Subject: src: xml: use nodes instead of attributes

When working with XML, it's desirable to work with nodes better than
attributes.

Table/chain/rules had attributes in their XML representation, and
this patch transform those to nodes, ie:

Before:
<table name="filter">
	<family>ip</family>
	<table_flags>0</table_flags>
</table>

After:
<table>
	<name>filter</name>
	<family>ip</family>
	<table_flags>0</table_flags>
</table>

While at it:
 * There was a lot of redundant code that is now collapsed with the
new nft_mxml_family_parse() helper function.

 * I've added a small fix: additional validation for the name of
the current XML object, and also replace raw strtol calls to nft_strtoi.

 * Also, all XML testfiles are updated to keep passing the parsing tests and
mantain the repo in consisten state.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 tests/xmlfiles/41-rule-real.xml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

(limited to 'tests/xmlfiles/41-rule-real.xml')

diff --git a/tests/xmlfiles/41-rule-real.xml b/tests/xmlfiles/41-rule-real.xml
index 58c13d0..de951f8 100644
--- a/tests/xmlfiles/41-rule-real.xml
+++ b/tests/xmlfiles/41-rule-real.xml
@@ -1,4 +1,8 @@
-<rule family="ip" table="filter" chain="output" handle="3">
+<rule>
+	<family>ip</family>
+	<table>filter</table>
+	<chain>output</chain>
+	<handle>3</handle>
 	<rule_flags>0</rule_flags>
 	<expr type="payload">
 		<dreg>1</dreg>
-- 
cgit v1.2.3