diff options
| author | Eric Leblond <eric@regit.org> | 2017-07-11 00:32:51 +0200 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2017-07-17 17:20:34 +0200 |
| commit | 07bf0d4a215337fb710cdaa73b1cae3f7a307e96 (patch) | |
| tree | 81cbc46bb3b0f43c5294709bf625a041f740c011 | |
| parent | a82f609ea2d8ab05e00b45e28db207fc8bfd0e32 (diff) | |
parser: fix bison warnings
We had the following warnings
parser_bison.y:1089:10: warning: variable 'cmd' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (erec != NULL) {
^~~~~~~~~~~~
parser_bison.y:1095:39: note: uninitialized use occurs here
(yyval.cmd) = cmd_alloc(CMD_LIST, cmd, &(yyvsp[0].handle), &(yyloc), NULL);
^~~
parser_bison.y:1089:6: note: remove the 'if' if its condition is always true
if (erec != NULL) {
^~~~~~~~~~~~~~~~~~
parser_bison.y:1080:12: note: initialize the variable 'cmd' to silence this warning
int cmd;
^
= 0
Signed-off-by: Eric Leblond <eric@regit.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
| -rw-r--r-- | src/parser_bison.y | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/parser_bison.y b/src/parser_bison.y index 45f134a8..abc41a6b 100644 --- a/src/parser_bison.y +++ b/src/parser_bison.y @@ -1093,7 +1093,8 @@ list_cmd : TABLE table_spec if (erec != NULL) { erec_queue(erec, state->msgs); YYERROR; - } + } else + YYERROR; } $$ = cmd_alloc(CMD_LIST, cmd, &$4, &@$, NULL); |