summaryrefslogtreecommitdiffstats
path: root/src/mnl.c
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2014-01-09 18:54:02 +0000
committerPatrick McHardy <kaber@trash.net>2014-01-09 18:54:02 +0000
commitf930cc50031851c6975058e33408214ad0c240b6 (patch)
treefb9cb26875448789bf602aeec1886c0c7493edf1 /src/mnl.c
parenta54d7b05fb241dae62039d2c200e9a18941cf250 (diff)
nftables: fix supression of "permission denied" errors
Introduction of batch support broke displaying of EPERM since those are generated by the kernel before batch processing starts and thus have the sequence number of the NFNL_MSG_BATCH_BEGIN message instead of the command messages. Also only a single error message is generated for the entire batch. This patch fixes this by noting the batch sequence number and displaying the error for all commands since this is what would happen if the permission check was inside batch processing as every other check. Signed-off-by: Patrick McHardy <kaber@trash.net>
Diffstat (limited to 'src/mnl.c')
-rw-r--r--src/mnl.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/src/mnl.c b/src/mnl.c
index a711b5e2..a4a4c4af 100644
--- a/src/mnl.c
+++ b/src/mnl.c
@@ -106,7 +106,7 @@ static void mnl_batch_page_add(void)
batch = mnl_batch_alloc();
}
-static void mnl_batch_put(int type)
+static uint32_t mnl_batch_put(int type)
{
struct nlmsghdr *nlh;
struct nfgenmsg *nfg;
@@ -123,11 +123,13 @@ static void mnl_batch_put(int type)
if (!mnl_nlmsg_batch_next(batch))
mnl_batch_page_add();
+
+ return nlh->nlmsg_seq;
}
-void mnl_batch_begin(void)
+uint32_t mnl_batch_begin(void)
{
- mnl_batch_put(NFNL_MSG_BATCH_BEGIN);
+ return mnl_batch_put(NFNL_MSG_BATCH_BEGIN);
}
void mnl_batch_end(void)