diff options
| author | Liping Zhang <liping.zhang@spreadtrum.com> | 2016-05-29 19:25:37 +0800 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2016-05-30 11:55:47 +0200 |
| commit | 1f327272e968a72de2d2a56da69124b40aa38744 (patch) | |
| tree | e222b62fee92706cbd94226767b135e9e0fbcc06 /src | |
| parent | d73b6b39f66ff477831e69f40e47fb7faa426ce3 (diff) | |
parser: fix crash if we add a chain with an error chain type
If we add a chain and specify the nonexistent chain type, chain_type_name_lookup
will return a NULL pointer, and meet the assert condition in xstrdup.
Fix crash like this:
# nft add chain filter input {type none hook input priority 0\;}
nft: utils.c:63: xstrdup: Assertion `s != ((void *)0)' failed.
Aborted (core dumped)
Signed-off-by: Liping Zhang <liping.zhang@spreadtrum.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/parser_bison.y | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/parser_bison.y b/src/parser_bison.y index 0452b8f4..ef10dee2 100644 --- a/src/parser_bison.y +++ b/src/parser_bison.y @@ -1124,12 +1124,14 @@ type_identifier : STRING { $$ = $1; } hook_spec : TYPE STRING HOOK STRING dev_spec PRIORITY prio_spec { - $<chain>0->type = xstrdup(chain_type_name_lookup($2)); - if ($<chain>0->type == NULL) { + const char *chain_type = chain_type_name_lookup($2); + + if (chain_type == NULL) { erec_queue(error(&@2, "unknown chain type %s", $2), state->msgs); YYERROR; } + $<chain>0->type = xstrdup(chain_type); xfree($2); $<chain>0->hookstr = chain_hookname_lookup($4); |