path: root/tests/py/inet/icmp.t
diff options
authorPhil Sutter <>2018-06-21 14:01:13 +0200
committerFlorian Westphal <>2018-06-26 16:23:21 +0200
commit056aaa3e6dc65aced5e552233ac3e7f89fb81f86 (patch)
treeb3fc68dd87fcf94f8b5f10c23eae216e67245de8 /tests/py/inet/icmp.t
parent78ba4ffdeacc9b31f7396d72c98907e861024653 (diff)
netlink_delinearize: Refactor meta_may_dependency_kill()
The original intent was to fix a bug: The following rule in inet table: | meta nfproto ipv4 icmpv6 type echo-reply Was added correctly but when printing the meta match was falsely removed. The fix is to deny dependency killing if RHS family of nfproto match doesn't match RHS family of l4proto match. Adding this to the already large conditional led to even more unreadable code, therefore this patch tries to clean that up (and also removes the partial code duplication. Signed-off-by: Phil Sutter <> Signed-off-by: Florian Westphal <>
Diffstat (limited to 'tests/py/inet/icmp.t')
1 files changed, 18 insertions, 0 deletions
diff --git a/tests/py/inet/icmp.t b/tests/py/inet/icmp.t
new file mode 100644
index 00000000..9014f846
--- /dev/null
+++ b/tests/py/inet/icmp.t
@@ -0,0 +1,18 @@
+:output;type filter hook output priority 0
+# without nfproto specified, these should add an implicit dependency on
+# the likely l3 proto (i.e., IPv6 for icmpv6 and IPv4 for icmp)
+icmp type echo-request;ok
+icmpv6 type echo-request;ok
+# make sure only those nfproto matches are dropped if
+# the next statement would add it as a dependency anyway
+meta nfproto ipv4 icmp type echo-request;ok;icmp type echo-request
+meta nfproto ipv4 icmpv6 type echo-request;ok
+meta nfproto ipv6 icmp type echo-request;ok
+meta nfproto ipv6 icmpv6 type echo-request;ok;icmpv6 type echo-request