From 00487d5fe3ece179e61124ee62449f4ad7d1918e Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Mon, 21 Oct 2019 16:20:10 +0200 Subject: parser_json: Fix checking of parse_policy() return code The function was changed to return an expression or NULL but error checking wasn't adjusted while doing so. Fixes: dba4a9b4b5fe2 ("src: allow variable in chain policy") Signed-off-by: Phil Sutter Acked-by: Pablo Neira Ayuso --- src/parser_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parser_json.c b/src/parser_json.c index 55dbc177..fe0c5df9 100644 --- a/src/parser_json.c +++ b/src/parser_json.c @@ -2630,7 +2630,7 @@ static struct cmd *json_parse_cmd_add_chain(struct json_ctx *ctx, json_t *root, chain->dev = xstrdup(chain->dev); if (!json_unpack(root, "{s:s}", "policy", &policy)) { chain->policy = parse_policy(policy); - if (chain->policy < 0) { + if (!chain->policy) { json_error(ctx, "Unknown policy '%s'.", policy); chain_free(chain); return NULL; -- cgit v1.2.3