From f211921e25e683eb0cbfac08fd0289a07b6d67d1 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Wed, 5 Jun 2019 17:07:42 +0200 Subject: src: perform evaluation after parsing Since 61236968b7a1 ("parser: evaluate commands immediately after parsing"), evaluation is invoked from the parsing phase in order to improve error reporting. However, this approach is problematic from the cache perspective since we don't know if a full or partial netlink dump from the kernel is needed. If the number of objects in the kernel is significant, the netlink dump operation to build the cache may significantly slow down commands. This patch moves the evaluation phase after the parsing phase as a preparation update to allow for a better strategy to build the cache. Signed-off-by: Pablo Neira Ayuso --- include/parser.h | 1 - 1 file changed, 1 deletion(-) (limited to 'include') diff --git a/include/parser.h b/include/parser.h index a5ae802b..39a75212 100644 --- a/include/parser.h +++ b/include/parser.h @@ -27,7 +27,6 @@ struct parser_state { unsigned int scope; struct list_head *cmds; - struct eval_ctx ectx; }; struct mnl_socket; -- cgit v1.2.3