From 55b825559d1070c6addc541bb5761f4734c03c62 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Thu, 28 Jan 2016 13:03:03 +0100 Subject: evaluate: assert on invalid base in resolve_protocol_conflict() We already have similar code in the tree, we shouldn't see bases over transport yet. Signed-off-by: Pablo Neira Ayuso --- src/evaluate.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to 'src/evaluate.c') diff --git a/src/evaluate.c b/src/evaluate.c index eb442d54..b70ff07c 100644 --- a/src/evaluate.c +++ b/src/evaluate.c @@ -392,6 +392,7 @@ static int resolve_protocol_conflict(struct eval_ctx *ctx, struct expr *payload) { enum proto_bases base = payload->payload.base; + const struct proto_desc *next; struct stmt *nstmt = NULL; int link, err; @@ -402,18 +403,17 @@ static int resolve_protocol_conflict(struct eval_ctx *ctx, return err; } - if (base < PROTO_BASE_MAX) { - const struct proto_desc *next = ctx->pctx.protocol[base + 1].desc; + assert(base < PROTO_BASE_MAX); + next = ctx->pctx.protocol[base + 1].desc; - if (payload->payload.desc == next) { - ctx->pctx.protocol[base + 1].desc = NULL; - ctx->pctx.protocol[base].desc = next; - ctx->pctx.protocol[base].offset += desc->length; - payload->payload.offset += desc->length; - return 0; - } else if (next) { - return 1; - } + if (payload->payload.desc == next) { + ctx->pctx.protocol[base + 1].desc = NULL; + ctx->pctx.protocol[base].desc = next; + ctx->pctx.protocol[base].offset += desc->length; + payload->payload.offset += desc->length; + return 0; + } else if (next) { + return 1; } link = proto_find_num(desc, payload->payload.desc); -- cgit v1.2.3