From 4be0a3f922a2944a941316fad76a717cd46691bd Mon Sep 17 00:00:00 2001 From: Phil Sutter Date: Mon, 19 Mar 2018 18:02:05 +0100 Subject: flowtable: Make parsing a little more robust It was surprisingly easy to crash nft with invalid syntax in 'add flowtable' command. Catch at least three possible ways (illustrated in provided test case) by making evaluation phase survive so that bison gets a chance to complain. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- src/expression.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/expression.c') diff --git a/src/expression.c b/src/expression.c index 5f023d2a..e698b14c 100644 --- a/src/expression.c +++ b/src/expression.c @@ -65,7 +65,7 @@ void expr_free(struct expr *expr) return; if (--expr->refcnt > 0) return; - if (expr->ops->destroy) + if (expr->ops && expr->ops->destroy) expr->ops->destroy(expr); xfree(expr); } -- cgit v1.2.3