From cc285973eeeebfa44b61f4ba2f8a5648a52d401e Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Mon, 24 May 2021 22:05:02 +0200 Subject: expression: display an error on unknown datatype # nft describe foo datatype foo is invalid Fixes: 21cbab5b6ffe ("expression: extend 'nft describe' to allow listing data types") Signed-off-by: Pablo Neira Ayuso --- src/expression.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/expression.c') diff --git a/src/expression.c b/src/expression.c index 7ae075d2..c9133363 100644 --- a/src/expression.c +++ b/src/expression.c @@ -135,9 +135,12 @@ void expr_describe(const struct expr *expr, struct output_ctx *octx) nft_print(octx, "datatype %s (%s)", dtype->name, dtype->desc); len = dtype->size; - } else { + } else if (dtype != &invalid_type) { nft_print(octx, "%s expression, datatype %s (%s)", expr_name(expr), dtype->name, dtype->desc); + } else { + nft_print(octx, "datatype %s is invalid\n", expr->identifier); + return; } if (dtype->basetype != NULL) { -- cgit v1.2.3