From e3f195777ee54c7a57aab932b64c6ecbd782f68f Mon Sep 17 00:00:00 2001 From: Florian Westphal Date: Fri, 8 Feb 2019 17:02:23 +0100 Subject: src: expr: remove expr_ops from struct expr size of struct expr changes from 144 to 128 bytes on x86_64. This doesn't look like much, but large rulesets can have tens of thousands of expressions (each set element is represented by an expression). Signed-off-by: Florian Westphal --- src/meta.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/meta.c') diff --git a/src/meta.c b/src/meta.c index 4cb91773..7e44a2a3 100644 --- a/src/meta.c +++ b/src/meta.c @@ -553,7 +553,7 @@ static void meta_expr_pctx_update(struct proto_ctx *ctx, } } -static const struct expr_ops meta_expr_ops = { +const struct expr_ops meta_expr_ops = { .type = EXPR_META, .name = "meta", .print = meta_expr_print, @@ -568,7 +568,7 @@ struct expr *meta_expr_alloc(const struct location *loc, enum nft_meta_keys key) const struct meta_template *tmpl = &meta_templates[key]; struct expr *expr; - expr = expr_alloc(loc, &meta_expr_ops, tmpl->dtype, + expr = expr_alloc(loc, EXPR_META, tmpl->dtype, tmpl->byteorder, tmpl->len); expr->meta.key = key; -- cgit v1.2.3