From e3f195777ee54c7a57aab932b64c6ecbd782f68f Mon Sep 17 00:00:00 2001 From: Florian Westphal Date: Fri, 8 Feb 2019 17:02:23 +0100 Subject: src: expr: remove expr_ops from struct expr size of struct expr changes from 144 to 128 bytes on x86_64. This doesn't look like much, but large rulesets can have tens of thousands of expressions (each set element is represented by an expression). Signed-off-by: Florian Westphal --- src/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/socket.c') diff --git a/src/socket.c b/src/socket.c index d90b0416..e10b3226 100644 --- a/src/socket.c +++ b/src/socket.c @@ -43,7 +43,7 @@ static void socket_expr_clone(struct expr *new, const struct expr *expr) new->socket.key = expr->socket.key; } -static const struct expr_ops socket_expr_ops = { +const struct expr_ops socket_expr_ops = { .type = EXPR_SOCKET, .name = "socket", .print = socket_expr_print, @@ -57,7 +57,7 @@ struct expr *socket_expr_alloc(const struct location *loc, enum nft_socket_keys const struct socket_template *tmpl = &socket_templates[key]; struct expr *expr; - expr = expr_alloc(loc, &socket_expr_ops, tmpl->dtype, + expr = expr_alloc(loc, EXPR_SOCKET, tmpl->dtype, tmpl->byteorder, tmpl->len); expr->socket.key = key; -- cgit v1.2.3